Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the offer data explicitly to the feedback form #349

Merged
merged 1 commit into from
May 17, 2019
Merged

Conversation

willbarton
Copy link
Member

@willbarton willbarton commented May 14, 2019

The feedback form had previously acquired the offer data indirectly from the referrer URL. This change passes that data directly to the form in the form of the query string so that it can be recorded along with the message. This should fix the current issues of the referrer being blank by explicitly providing the data needed.

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 99.959% when pulling a488c58 on fix-feedback into 277ef0f on master.

@coveralls
Copy link

coveralls commented May 14, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling e36e5a1 on fix-feedback into 277ef0f on master.

The feedback form had previously aquired the offer data indirectly from the referrer URL. This change passes that data directly to the form in the form of the query string so that it can be recorded along with the message. This should fix the current issues of the referrer being blank by explicitly providing the data needed.
Copy link
Collaborator

@schbetsy schbetsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, I was able to submit feedback through the form, and I saw that the query string (including program information) was saved in the url field of the feedback. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants