Add script for validating redirects #6023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpears
requested changes
Sep 22, 2020
| default='https://www.consumerfinance.gov', | ||
| nargs='?' | ||
| ) | ||
|
|
There was a problem hiding this comment.
With the comment above, let's add arguments for the from and to indexes
There was a problem hiding this comment.
Excellent suggestion as always. Will do.
There was a problem hiding this comment.
@wpears just added a commit that adds optional --from-index and --to-index parameters, for review at your convenience.
This new script allows for validation of a set of redirects as defined in a CSV or XLSX file. The first line of the file will be ignored as headers. The "from" and "to" paths must live in the 6th and 7th column of the input file, respectively. To run against www.consumerfinance.gov, using an input XLSX: cfgov/scripts/validate_redirects.py redirects.xlsx To run against localhost, using an input CSV: cfgov/scripts/validate_redirects.py redirects.csv http://localhost:8000 To test, run without one of the redirects and observe that the check fails. Now add the redirect and note that the check passes as long as it redirects to the correct path.
chosak
force-pushed
the
feature/validate-redirects-cmd
branch
from
ae88224
to
901771f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new script allows for validation of a set of redirects as defined in a CSV or XLSX file. The first line of the file will be ignored as headers. The "from" and "to" paths default to being read from the 6th and 7th column of the input file, respectively.
To run against www.consumerfinance.gov, using an input XLSX:
To run against localhost, using an input CSV:
To specify alternate CSV columns for the "from" and "to" paths:
How to test this PR
To test, run without one of the redirects and observe that the check fails. Now add the redirect and note that the check passes as long as it redirects to the correct path.
Checklist