Make mega-menu content-2 flyout width content-independent #6043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpears
force-pushed
the
mega-menu-tablet-flyout
branch
from
70306fb
to
165f15b
Compare
…endent of content
chosak
force-pushed
the
mega-menu-tablet-flyout
branch
from
9d001c4
to
be77590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.local/CFPB/super-regular/issues/162
Previously, between 901px and 1260px, the width of the mega menu flyout could change based on the content. This was somewhat hard to reproduce and resolved around
display: table-cellweirdness of the child columns.This now sets an explicit
width: 100%;between those dimensions, which keeps the flyout a constant width, not matter the number of columns/presence of an overview link, etc.Before:
After:
