Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libraries for django-elasticsearch-dsl and deploy configuration #6057

Merged
merged 6 commits into from
Oct 1, 2020

Conversation

alexm118
Copy link
Contributor

@alexm118 alexm118 commented Oct 1, 2020

Decomposes more of the Ask-CFPB work we've been doing into smaller PRs. This builds onto #6052 which now involves deploying ES7 as part of our docker stack. We've setup a flag in our ansible configuration to determine if we should configure connections to an AWS ES Cluster, or if we should default back to our standard configuration and default to an empty connection string if there is no configured ES7 Host.


Additions

  • Configure and include django-elasticsearch-dsl connection in base.py including working configuration with an AWS ES Cluster if provided.
  • Forked elasticsearch-dsl dependency where we reference elasticsearch as elasticsearch7
  • requests_4awsauth to connect with AWS ES.

How to test this PR

  1. App should be able to run locally, on docker enterprise, and on a DEV server even if configuration is missing such as ES7_HOST

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines
  • Future todos are captured in comments and/or tickets
  • Project documentation has been updated, potentially one or more of:
    • This repo’s docs (edit the files in the /docs folder) – for basic, close-to-the-code docs on working with this repo
    • CFGOV/platform wiki on GHE – for internal CFPB developer guidance
    • CFPB/hubcap wiki on GHE – for internal CFPB design and content guidance

Copy link
Contributor

@cwdavies cwdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great approach to just add libraries for elasticsearch-dsl in a separate PR instead of all the changes in the Ask ES PR

Copy link
Contributor

@Scotchester Scotchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me in local Docker and virtualenv setups!

@alexm118 alexm118 merged commit 026c105 into main Oct 1, 2020
@alexm118 alexm118 deleted the ES7-Configuration-DSL branch October 1, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants