Keep duplicated filterable list params when paginating #6061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2199 from over 4 years ago!
The problem here stemmed from the use of
request.GET.items()
, which returns only the last value when multiple params have the same key, by design.See https://docs.djangoproject.com/en/3.1/ref/request-response/#django.http.QueryDict.items
Changing to
.lists()
and updating the logic a bit to handle the resulting lists stops params from being dropped.Also, filtering out the 'page' param prevents the other bug here which was repeated page params in the querystring.