Fix the nmdb CSV export by calling getvalue() #6064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why this cropped up now, but along the way we lost the ability to feed a bare file object to boto3 for uploading to S3. Boto creates and md5 hash of the content and expects bytes in making the hash, and our previous code delivered unicode. The solution is to pass the bytes instead of the file object to boto, by calling `getvalue()` on the file object.
higs4281
force-pushed
the
fix-nmdb-csv-export
branch
from
37b9fc6
to
a533989
Compare
willbarton
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this cropped up now, but along the way we lost the ability
to feed a file object to boto3 for uploading to S3. Boto creates a
hash of the content and expects bytes in making the hash, and
our previous routine delivered unicode.
The solution is to pass the bytes instead of the file object to boto,
by calling
getvalue()on the file object.Testing
I ran the zusa prep job
cf.gov-nmdb-data-prepagainst this branch, and it succeeded. The charts on DEV5 and CSV downloads on S3 look good.