Remove double zipping from frontend artifacts #7958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's actually a fairly significant time penalty to this ~25s and ways to work around it in action code, so I'm going to close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the existing frontend artifacts are double-zipped. See, eg, https://github.com/cfpb/consumerfinance.gov/actions/runs/6176453940, where the frontend_3b4a6aae0eedc329cc218bdf05ebac9aa2d61482.zip download, when unzipped, results in a
frontend.zipfile.This fixes that by removing the intermediate zip.
(this doesn't actually fix that in the run triggered by this PR, but will in the future)