-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate layout-full to CSS grid #8164
Conversation
@@ -28,568 +28,565 @@ | |||
{% endblock %} | |||
|
|||
{% block body_content %} | |||
<div class="content_wrapper"> | |||
<div class="content_main u-pb0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The viz checker is showing that removing content_main
is causing paragraphs to not get wrapped on the rate checker:
before | after |
---|---|
Also it looks like the iregs search loses some padding:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! The only other thing the tool picked up is that there's leftover gutter padding from content_main
on the financial literacy pages:
before | after |
---|---|
@contolini updates are in rate explorer/kbyo iregs search TDP ty ty ty!! |
FYI I rewrote the rate explorer brand footer in flexbox to reduce the styles. One consequence of this is the items in the footer wrap a little different across screen sizes. I think it's fine. |
Additions
u-layout-grid_breakout
class for blocks that bleed out of the CSS grid to the browser window edge.Changes
How to test this PR
Form explainer:
http://localhost:8000/owning-a-home/loan-estimate/
CCDB
http://localhost:8000/data-research/consumer-complaints/search/
Gov-delivery
https://www.consumerfinance.gov/govdelivery-subscribe/success/
https://www.consumerfinance.gov/govdelivery-subscribe/error/
Know Before You Owe
http://localhost:8000/know-before-you-owe/
http://localhost:8000/know-before-you-owe/compare/
http://localhost:8000/know-before-you-owe/timeline/
Rate Explorer
http://localhost:8000/owning-a-home/explore-rates/
Transcript
http://localhost:8000/transcripts/how-to-apply-for-a-federal-job-with-the-cfpb/
Mega Menu Preview
Go into Wagtail admin and go to the Mega Menu settings and hit "Preview"
Prepaid agreements
http://localhost:8000/data-research/prepaid-accounts/search-agreements/
iRegs
http://localhost:8000/rules-policy/regulations/1002/
Before You Claim
http://localhost:8000/consumer-tools/retirement/before-you-claim/
TDP activities search
http://localhost:8000/consumer-tools/educator-tools/youth-financial-education/teach/activities/
Story page
http://localhost:8000/about-us/racial-equity/
http://localhost:8000/about-us/small-business-lending/
http://localhost:8000/es/quienes-somos/prestamos-pequenos-negocios/
Recent updates
http://localhost:8000/activity-log
Spanish homepage
http://localhost:8000/es/
Homepage
http://localhost:8000/
400 and 500 error pages
Before you claim - Added block to content are to fix issue where there was no padding at the bottom of the content area.
http://localhost:8000/consumer-tools/retirement/before-you-claim/about/