Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate layout-full to CSS grid #8164

Merged
merged 17 commits into from
Mar 6, 2024
Merged

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Feb 22, 2024

Additions

  • Added u-layout-grid_breakout class for blocks that bleed out of the CSS grid to the browser window edge.

Changes

  • Add block around /consumer-tools/retirement/before-you-claim/about/ content area to fix problem where content bottom was erroneously flush.

How to test this PR

  1. These pages use the layout full template. They should not be broken:

Form explainer:
http://localhost:8000/owning-a-home/loan-estimate/

CCDB
http://localhost:8000/data-research/consumer-complaints/search/

Gov-delivery
https://www.consumerfinance.gov/govdelivery-subscribe/success/
https://www.consumerfinance.gov/govdelivery-subscribe/error/

Know Before You Owe
http://localhost:8000/know-before-you-owe/
http://localhost:8000/know-before-you-owe/compare/
http://localhost:8000/know-before-you-owe/timeline/

Rate Explorer
http://localhost:8000/owning-a-home/explore-rates/

Transcript
http://localhost:8000/transcripts/how-to-apply-for-a-federal-job-with-the-cfpb/

Mega Menu Preview
Go into Wagtail admin and go to the Mega Menu settings and hit "Preview"

Prepaid agreements
http://localhost:8000/data-research/prepaid-accounts/search-agreements/

iRegs
http://localhost:8000/rules-policy/regulations/1002/

Before You Claim
http://localhost:8000/consumer-tools/retirement/before-you-claim/

TDP activities search
http://localhost:8000/consumer-tools/educator-tools/youth-financial-education/teach/activities/

Story page
http://localhost:8000/about-us/racial-equity/
http://localhost:8000/about-us/small-business-lending/
http://localhost:8000/es/quienes-somos/prestamos-pequenos-negocios/

Recent updates
http://localhost:8000/activity-log

Spanish homepage
http://localhost:8000/es/

Homepage
http://localhost:8000/

400 and 500 error pages

  1. Temporarily change this line to False.
  2. Run ALLOW_ADMIN_URL=1 cfgov/manage.py runserver --insecure
  3. To test the 404 template: visit http://localhost:8000/something-that-doesnt-exist/
  4. To test the 500 template: visit http://localhost:8000/admin/failwhale/

Before you claim - Added block to content are to fix issue where there was no padding at the bottom of the content area.
http://localhost:8000/consumer-tools/retirement/before-you-claim/about/

@anselmbradford anselmbradford marked this pull request as ready for review February 29, 2024 15:58
@@ -28,568 +28,565 @@
{% endblock %}

{% block body_content %}
<div class="content_wrapper">
<div class="content_main u-pb0">
Copy link
Member

@contolini contolini Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The viz checker is showing that removing content_main is causing paragraphs to not get wrapped on the rate checker:

before after
image image

@contolini
Copy link
Member

Also it looks like the iregs search loses some padding:

before after
image image

@contolini contolini self-requested a review March 5, 2024 21:43
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! The only other thing the tool picked up is that there's leftover gutter padding from content_main on the financial literacy pages:

before after
image Screenshot 2024-03-05 at 4 49 12 PM

@anselmbradford
Copy link
Member Author

@contolini updates are in

rate explorer/kbyo
b59c169

iregs search
9f8ddf2

TDP
b714e22

ty ty ty!!

@anselmbradford
Copy link
Member Author

FYI I rewrote the rate explorer brand footer in flexbox to reduce the styles. One consequence of this is the items in the footer wrap a little different across screen sizes. I think it's fine.

@anselmbradford anselmbradford added this pull request to the merge queue Mar 6, 2024
@anselmbradford anselmbradford removed this pull request from the merge queue due to a manual request Mar 6, 2024
@anselmbradford anselmbradford added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit fdce62b Mar 6, 2024
17 of 18 checks passed
@anselmbradford anselmbradford deleted the ans_migrate_full_layout branch March 6, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants