Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credit card agreement database: migrate to use standard layout 2-1 template #8180

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Credit card agreement database: migrate to use standard layout 2-1 template #8180

merged 2 commits into from
Mar 6, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Mar 1, 2024 •
edited
Loading

Changes

  • Credit card agreement database: migrate to use standard layout 2-1 template

How to test this PR

  1. The three agreement templates are as follows. They should largely be unchanged, but you will see when you resize to mobile that the breadcrumbs are in our standard breadcrumb gray box:

Landing page
http://localhost:8000/credit-cards/agreements/

Archive
http://localhost:8000/credit-cards/agreements/archive/

Individual entry (example)
http://localhost:8000/credit-cards/agreements/issuer/1st-summit-bank/

Screenshots

Before:
Screenshot 2024-03-01 at 2 19 40 PM

After:
Screenshot 2024-03-01 at 2 19 27 PM

@anselmbradford anselmbradford added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 1d01ac2 Mar 6, 2024
12 checks passed
@anselmbradford anselmbradford deleted the ans_agreement_layout branch March 6, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpears wpears wpears approved these changes

@mistergone mistergone Awaiting requested review from mistergone

@willbarton willbarton Awaiting requested review from willbarton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anselmbradford @wpears