-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add directory table pattern to base table template #8183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds our directory table pattern that's already in the DS to our cf.gov table organism template. Also adds a modified version of the pattern to TCCP that sticks the top rows to the viewport when scrolling. See https://cfpb.github.io/design-system/components/tables#responsive-stacked-table-with-header-directory-table See https://github.local/Design-Development/Design-Thinking-and-User-Research/issues/232
chosak
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful.
Comment on lines
+52
to
+53
{%- set stack_on_mobile = 'stack_on_mobile' in (value.options or []) or 'directory_table' in (value.options or []) -%} | ||
{%- set directory_table = 'directory_table' in (value.options or []) -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
{%- set stack_on_mobile = 'stack_on_mobile' in (value.options or []) or 'directory_table' in (value.options or []) -%} | |
{%- set directory_table = 'directory_table' in (value.options or []) -%} | |
{%- set directory_table = 'directory_table' in (value.options or []) -%} | |
{%- set stack_on_mobile = directory_table or ('stack_on_mobile' in (value.options or [])) -%} |
contolini
added a commit
that referenced
this pull request
Mar 4, 2024
contolini
added a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds our directory table pattern that's already in the DS to our cf.gov table organism template.
Also iterates on our card listing page by using a new directory table variant that sticks the top rows to the viewport when scrolling.
See https://cfpb.github.io/design-system/components/tables#responsive-stacked-table-with-header-directory-table
See https://github.local/Design-Development/Design-Thinking-and-User-Research/issues/232
Changes
How to test this PR
./frontend.sh
Screenshots
Checklist
/docs
folder) – for basic, close-to-the-code docs on working with this repoFront-end testing
Browser testing
Visually tested in the following supported browsers:
Accessibility
Other