Improve summary by diffing all intended files #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the generate_summary.sh script so that it takes an argument that can be used to indicate which files to diff. Previously, only HTML files were being diffed, but due to long URLs, wget may download files that end in other extensions. Additionally, this changes the workflow file so that we only define the domain to crawl in a single place.
schbetsy
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the generate_summary.sh script so that it takes an argument that can be used to indicate which files to diff. Previously, only HTML files were being diffed, but due to long URLs, wget may download files that end in other extensions (see problem 2 at #13 (comment)).
Additionally, this changes the workflow file so that we only define the domain to crawl in a single place.