Skip to content
This repository has been archived by the owner on Feb 1, 2019. It is now read-only.

Add breadcrumbs, UI tweaks #6

Merged
merged 22 commits into from
Aug 3, 2015
Merged

Add breadcrumbs, UI tweaks #6

merged 22 commits into from
Aug 3, 2015

Conversation

contolini
Copy link
Member

This PR:

  • Brings over the /src build script stuff.
  • Adds a breadcrumbs component.
  • Cleans up the README and adds a coverage badge.
  • Cleans up icon alignment and some other UI stuff.

@dgreisen-cfpb @imuchnik

@imuchnik
Copy link
Member

Tried it locally and it seems to conflict with latest devdash changes. Let's hold off on it until after we deploy.
Breadcrumbs look nice, but the tests are missing.
👍 Obligatory.

@contolini
Copy link
Member Author

Abort!

@contolini contolini closed this May 12, 2015
@contolini
Copy link
Member Author

Un-abort!

@contolini contolini reopened this May 12, 2015
@imuchnik
Copy link
Member

First rejected PR due to the lack of tests. A milestone of sorts! A cause for celebrations?
Grateful @contolini is such a nice guy. 💯 🚀 🎢 🍰 🌹 🉑 👯 👊 ✊ 😂

imuchnik added a commit to imuchnik/dash that referenced this pull request Jul 16, 2015
Clean up gulpfile, fix all tests, add contributing docs to readme
@dgreisen-cfpb
Copy link
Contributor

yolo

dgreisen-cfpb added a commit that referenced this pull request Aug 3, 2015
Add breadcrumbs, UI tweaks
@dgreisen-cfpb dgreisen-cfpb merged commit 19e341c into cfpb:master Aug 3, 2015
@contolini
Copy link
Member Author

yesssss

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants