Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number options to Icon component #107

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Add number options to Icon component #107

merged 2 commits into from
Jul 19, 2023

Conversation

contolini
Copy link
Member

Adds numbers to the Icon component. Number icons exist in the icons directory but they're not mentioned on the DS website or used in cf.gov.

Changes

  • Adds number icons

How to test this PR

  1. PR tests should pass.
  2. Visit the PR preview and you should see numbers in the Icon section.

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit 8d00fa7
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/64b866dce1db120008ab080a
😎 Deploy Preview https://deploy-preview-107--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@contolini contolini enabled auto-merge (squash) July 18, 2023 18:53
src/components/Icon/Icon.tsx Outdated Show resolved Hide resolved
@meissadia meissadia self-requested a review July 19, 2023 22:43
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@contolini contolini merged commit 19e8899 into main Jul 19, 2023
6 checks passed
@contolini contolini deleted the number-icons branch July 19, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants