Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Footer] Propagate attributes #129

Merged
merged 3 commits into from
Aug 9, 2023
Merged

[Footer] Propagate attributes #129

merged 3 commits into from
Aug 9, 2023

Conversation

meissadia
Copy link
Contributor

Closes #128

  • Integrate passed className into class derivation logic
  • Create tests. 100% coverage of Footer elements

How to test this PR

  1. yarn && yarn start
  2. yarn vitest Footer

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit e144606
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/64d29aa26a1da60007bf53a6
😎 Deploy Preview https://deploy-preview-129--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@contolini contolini merged commit 505034c into main Aug 9, 2023
6 checks passed
@contolini contolini deleted the 128-footer-propagate branch August 9, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Footer] Propagate all supported properties to underlying HTML elements
2 participants