Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cfpb fork of display-element-css Storybook addon #140

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Aug 10, 2023

Closes #123

  • CFPB fork of display-element-css created
  • Modified that repo to include the /dist/ folder so that things would work when installed from Github
  • Refactored to search parent element's styles
  • Attempts to filter output to only relevant styles
  • It kinda works!

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit afa5cf0
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/64da70c8eb528f00088570b5
😎 Deploy Preview https://deploy-preview-140--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia force-pushed the 123-css-tab-in-storybook branch 2 times, most recently from 8047919 to afa5cf0 Compare August 14, 2023 18:21
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉 Drives me a little crazy that you have to click the eyeball before anything will appear in the CSS tab. Clicking the CSS tab should auto-turn-on the eyeball IMHO.

@meissadia meissadia merged commit c75c2c8 into main Aug 14, 2023
6 checks passed
@meissadia meissadia deleted the 123-css-tab-in-storybook branch August 14, 2023 21:38
@meissadia
Copy link
Contributor Author

Clicking the CSS tab should auto-turn-on the eyeball IMHO.

We might be able to make that happen? I'd have to look into how the Storybook panels work and see if I can tie into the addon panel's switching logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easily view an element's CSS within Storybook
2 participants