Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Button] destructure className from props to avoid overwriting derived classnames #148

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Aug 14, 2023

Closes #111

  • Fixes bug
  • Adds test to ensure bug doesn't recur

How to test

  • yarn vitest Button

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit fae053c
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/64da8cd13841d400084c3824
😎 Deploy Preview https://deploy-preview-148--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia enabled auto-merge (squash) August 14, 2023 20:18
@meissadia meissadia merged commit 70e6d85 into main Aug 14, 2023
6 checks passed
@meissadia meissadia deleted the 111-button-propagate-part-2 branch August 14, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Button] Propagate all supported properties to underlying HTML elements
2 participants