Layout #78
Merged
Layout #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cfpb-design-stories ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Cleared merge conflicts. |
contolini
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
There are a handful of scenarios where various props can't be combined (e.g. 1-3 with a bleedbar) so if that ends up confusing people we should prob add logic to have one prop override others. For now I think this is great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77
Components to easily implement the
1-3and2-1style layoutsChanges
2-1and1-3layoutsHow to test this PR
Screenshots
Layout 1-3
Layout 2-1 w/ sidebar bleed
