First crack at property order reasoning #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Remaining properties are in alphabetical order. | ||
| 1. Display & box model | ||
| 1. Switching `display` and/or `box-sizing` |
There was a problem hiding this comment.
I'm a little confused by the use of "switching" here. Do you mean changing the default display or box-sizing values?
There was a problem hiding this comment.
Yes, that's what I meant. You're right, it could use clarification. I'll
update it.
There was a problem hiding this comment.
Updated in 5f740b1
|
Other than the comment above this looks great. Sorry for sitting on this for so long @Scotchester. |
|
👍 LGTM. Thanks @Scotchester! |
ascott1
added a commit
that referenced
this pull request
Jul 13, 2015
First crack at property order reasoning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know how this reads.
There's one property not shown here that I wonder about which group it belongs in:
content. This seems like a significant/non-decorative enough property to not go in the "other" bucket. Should it be listed in the first group?Any other ambiguous properties anyone else wonders about?
Closes #59