This repository has been archived by the owner on Feb 1, 2019. It is now read-only.
Progress bar #335
Merged
Progress bar #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 7, 2015 17:58
…the relevant type of tests being run
…a variable in the scope to hold a reference to the errors object. This was causing a problem in some circumstances where after $digest the values set in the $scope were reset to null. This wasn't a problem when we had the cfButton directive in place because it had an isolated scope and so once we passed the values into the directive they were no longer being updated in the controller after $digest. Still not 100% sure why this was happening, but this does fix the issue while only making the code a little more wordier in some places.
|
@porterbot added clearProgress() in 5135aec |
|
👍 Looks good to me.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #321
Note: The coverage will drop with this commit since I'm getting rid of the cfButton directive which had a 100% coverage.