Skip to content
This repository has been archived by the owner on Feb 1, 2019. It is now read-only.

Fix for cfpb/hmda-pilot#387, msa name = false in Q595 #133

Merged
merged 2 commits into from
May 4, 2015
Merged

Fix for cfpb/hmda-pilot#387, msa name = false in Q595 #133

merged 2 commits into from
May 4, 2015

Conversation

LinuxBozo
Copy link
Contributor

Sneaking in some test reliability fixes as well even though they aren't related.

@LinuxBozo
Copy link
Contributor Author

The mockAPI call gets held up by having to do the JSON.stringify (which btw, is expensive in time). This creates a timing issue because the engine call which uses that API endpoint fires before the mockAPI has the endpoint defined. If we do the stringify() synchronously first, we make sure that the mockAPI is setup before the engine call is made.

@doelleri
Copy link
Contributor

doelleri commented May 4, 2015

I had a feeling it was something like that. Thanks for the explanation.

doelleri added a commit that referenced this pull request May 4, 2015
@doelleri
Merge pull request #133 from LinuxBozo/milestone11
dc04abb 
Fix for cfpb/hmda-pilot#387, msa name = false in Q595
@doelleri doelleri merged commit dc04abb into cfpb:milestone11 May 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinuxBozo @doelleri