Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the HTML em dash entity #1

Merged
merged 2 commits into from
May 19, 2019
Merged

Fix the HTML em dash entity #1

merged 2 commits into from
May 19, 2019

Conversation

willbarton
Copy link
Member

@willbarton willbarton commented May 17, 2019 •
edited
Loading

My attempt to bring em-dash support directly into Regdown is impeded by using the wrong HTML entity. This PR fixes that.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@willbarton willbarton requested a review from a team May 17, 2019 21:33
@willbarton willbarton merged commit c28eb96 into master May 19, 2019
@willbarton willbarton deleted the fix-emdash branch May 19, 2019 15:44
@willbarton willbarton mentioned this pull request May 20, 2019
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scotchester Scotchester Scotchester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willbarton @Scotchester