Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormErrorHeader - Needs to be refactored to be flexibile #553

Closed
shindigira opened this issue May 21, 2024 · 0 comments · Fixed by #566
Closed

FormErrorHeader - Needs to be refactored to be flexibile #553

shindigira opened this issue May 21, 2024 · 0 comments · Fixed by #566
Assignees
@shindigira
Labels
post-mvp to be done after MVP deadline refactor Candidates for future refactor sprints

Comments

@shindigira
Copy link
Contributor

Currently used in both Complete your User Profile forms and Point of Contact. The input error message handling needs to be more "dumb" (flexible).
@shindigira shindigira added the post-mvp to be done after MVP deadline label May 21, 2024
@shindigira shindigira self-assigned this May 21, 2024
@shindigira shindigira added the refactor Candidates for future refactor sprints label May 21, 2024
@shindigira shindigira mentioned this issue May 22, 2024
Merged
5 tasks
shindigira added a commit that referenced this issue May 24, 2024
@shindigira
refactor(formErrorHeader), [Point of Contact] Field-level Errors Upda…
c107af1 
…te, [All Forms] Field-Level Errors and Header Errors content pass (#566)

closes #553 
closes #562 
closes #569 
closes #532

### Field level errors and form error header messages matching the
figma's
- [x] Complete Your User Profile 
- [x] Complete Your User Profile (No Assoc) 
- [x] Point of Contact
- [x] Types of Financial Institutions
- [x] Update your Financial Profile

## Changes
- chore(Point of Contact): Removed the `-- select option --` in the
states selection
- refactor(formErrorHeader): changed the component (used in all forms)
to be more flexible
- content(formErrorHeader): made a content pass to the field level
errors and header error messages

## How to Test
- Test every form and every input field, select or checkbox
- Compare with the figma

## Screenshots (Updated 05/23/2024)
### Note: Small content updates are present but not shown in the
screenshots

| Complete Your Profile | Complete Your Profile (No Assoc) |
|--|--|
|<img width="271" alt="Screenshot 2024-05-23 at 4 22 37 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/700cb925-04a5-4c41-80de-62557c18519a">|<img
width="271" alt="Screenshot 2024-05-23 at 4 19 09 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/19354d1e-bbcc-47b0-89a3-c59439979c65">|


| Point of Contact A | Point of Contact B |
|--|--|
|<img width="273" alt="Screenshot 2024-05-23 at 5 01 34 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/98ad9c57-94cd-4581-be7d-c951bda5d2a7">|<img
width="260" alt="Screenshot 2024-05-23 at 5 06 27 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/3b2b2e24-6ef3-4d59-a6fb-337e21f88f79">|



| Types of Financial Institutions A | Types of Financial Institutions B
|
|--|--|
|<img width="478" alt="Screenshot 2024-05-23 at 4 39 34 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/40c63aa3-fe22-40f9-9712-8153aad07dd5">|<img
width="481" alt="Screenshot 2024-05-23 at 4 39 49 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/42052ce4-124b-4c9f-bc3c-8e15cb5c25bb">|

| Update Financial Profile A | Update Financial Profile B | Update
Financial Profile C | Update Financial Profile D |
|--|--|--|--|
|<img width="530" alt="Screenshot 2024-05-23 at 4 03 29 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/5d1f667e-d686-4090-8001-fa4b03f743bb">|<img
width="528" alt="Screenshot 2024-05-23 at 4 03 39 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/e3cea4b4-983f-43c8-80c9-21d1871b3cf5">|<img
width="529" alt="Screenshot 2024-05-23 at 4 03 45 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/b146da17-7a95-49f2-938f-455bdb409947">|<img
width="402" alt="Screenshot 2024-05-23 at 4 03 54 PM"
src="https://github.com/cfpb/sbl-frontend/assets/13324863/b7991104-076e-4500-b35a-f69fb76967ea">|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shindigira shindigira

Labels
post-mvp to be done after MVP deadline refactor Candidates for future refactor sprints
Projects
None yet
Milestone
No milestone
1 participant
@shindigira