Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Point of Contact] State Selector - Error/Hover/Focus styling updates #561

Open
shindigira opened this issue May 22, 2024 · 5 comments
Open
Labels
enhancement New feature or request post-mvp to be done after MVP deadline UI Tasks involving visual elements

Comments

@shindigira
Copy link
Contributor

shindigira commented May 22, 2024

Changes needed

  • Have the outline/border not be covered by the droparrow box
  • Need design of hover and focus with and without an error state.

In this screenshot:
First element is a regular input -- red borders -- but hover is overriding the red borders
Second element is a select input -- red borders -- but hover is partially covering the red borders and with a different blue color

Screenshot 2024-05-21 at 11 39 51 PM
@shindigira shindigira added enhancement New feature or request UI Tasks involving visual elements post-mvp to be done after MVP deadline labels May 22, 2024
@shindigira shindigira changed the title [Point of Contact] State Selector - Hover/Focus [Point of Contact] State Selector - ErrorHover/Focus May 24, 2024
@shindigira shindigira changed the title [Point of Contact] State Selector - ErrorHover/Focus [Point of Contact] State Selector - Error/Hover/Focus styling updates May 24, 2024
@natalia-fitzgerald
Copy link

natalia-fitzgerald commented May 25, 2024

@shindigira
I made a ticket for making hover and focus more consistent across inputs. If we were to use the default hover and focus styling (Pacific blue) for the select and only used the status color when enabled (not for hover and focus) would this simplify the implementation?
cfpb/design-system-react#357

The select in the DSR and here should not include the "--select an option--" text by default. Helper text should be placed under the label and outside of the input field.

@natalia-fitzgerald
Copy link

@shindigira
This is a related ticket. cfpb/design-system-react#357

In the meantime, if you'd like to move forward (locally) with the styling for the input and select, here's the styling:

  • Hover: 2px solid Pacific border (#0072ce)
  • Focus: 1px dotted Pacific (#0072ce) outline on focus

Ultimately I'd like to make the more comprehensive change at the DS level but I know we're up against beta launch so perhaps handling locally is the only option.

@natalia-fitzgerald
Copy link

@shindigira
I reviewed this on AWS and I'm still seeing the red show through on hover and focus.
Screenshot 2024-06-03 at 10 39 43 PM

@natalia-fitzgerald
Copy link

@shindigira
The error state styling should look like this:
Screenshot 2024-06-08 at 12 22 54 AM

@natalia-fitzgerald
Copy link

@billhimmelsbach
This is related to the work that we have assigned for this sprint pulled from #800. Would you like to keep this ticket open or did you create a different one for this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request post-mvp to be done after MVP deadline UI Tasks involving visual elements
Projects
None yet
Development

No branches or pull requests

2 participants