fix: [Filing home] Update layout design #533
Conversation
|
Eventually, responsiveness should be addressed: Error conditions too: |
Added post-mvp tickets: |
| return <LoadingContent />; | ||
|
|
||
| // TODO: Implement logic to derive current filing period based on current date | ||
| // https://github.com/cfpb/sbl-frontend/issues/546 |
There was a problem hiding this comment.
import { DateTime } from 'luxon';
// Formatting: https://github.com/moment/luxon/blob/master/docs/formatting.md
const currentYear = DateTime.now().toFormat('y');There was a problem hiding this comment.
@shindigira The filing periods endpoint includes start/end/due dates for each filing period, so it may not be as simple as just "the current year"...or it might be, we'll need to check with the Regs folks.
On HMDA they also have Quarterly filing periods, which I don't think applies to SBL but is another item to verify with the Regs folks.
[
{
"code": "string",
"description": "string",
"start_period": "2024-05-21T20:49:34.045Z",
"end_period": "2024-05-21T20:49:34.045Z",
"due": "2024-05-21T20:49:34.045Z",
"filing_type": "ANNUAL"
}
]
| } | ||
| /> | ||
| <DisplayErrors | ||
| errors={!!associatedInstitutionsError || !!filingPeriodsError} |
There was a problem hiding this comment.
Not critical but maybe you want to change the prop's name to "boolean language" such as hasErrors.
|
Approved; only have non-critical nit feedback. Did not review content and styling. |
Part of #492
Changes
Screenshots