-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(home): add beta banner, beta/legal alert #560
Conversation
@natalia-fitzgerald @billhimmelsbach Does the beta banner need to be fixed to the top so that even when the user scrolls down -- said user still sees the banner? |
@shindigira @natalia-fitzgerald I don't think the designs had it fixed when we discussed it, and I'd probably argue that having it follow the user would be a lot heh. 🟨 👀 |
If we're following the CFPB default approach, and I believe that was our intent, it appears that the banner is not "fixed" to the top (does not follow the user as they scroll down the page). Here it is implemented: https://beta.consumerfinance.gov/ If there's a desire to consider a "fixed" beta banner we can discuss post MVP. But I think what you've implemented captures the design and the CFPB approach we were modeling. |
No desire from me. I think it would be a little weird for it to be fixed, so I'm happy as it is now and have it remain the same post-mvp @natalia-fitzgerald 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏾
Adds the beta and legal alert to the unauthenticated home page.
Closes #559
Changes
How to test this PR
Design questions
email our support staff
link in the Alert box on the unauthenticated home page? I set it to[BETA] Home page: Questions or suggestions
for now @natalia-fitzgeraldScreenshots
Notes