Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home): add beta banner, beta/legal alert #560

Merged
merged 5 commits into from
May 28, 2024

Conversation

billhimmelsbach
Copy link
Contributor

@billhimmelsbach billhimmelsbach commented May 22, 2024

Adds the beta and legal alert to the unauthenticated home page.

Closes #559

Changes

  • adds a beta banner to all pages
  • adds a beta/legal alert to the unauthenticated home page

How to test this PR

  1. Take a peek at the preview site
  2. See if the banner and alert look like the designs
  3. Test out the links in the alert
  4. Make sure the banner appears correct on other pages in the app

Design questions

  • what should the subject line be for the email our support staff link in the Alert box on the unauthenticated home page? I set it to [BETA] Home page: Questions or suggestions for now @natalia-fitzgerald

Screenshots

Screenshot 2024-05-21 at 11 32 50 PM

Notes

@shindigira
Copy link
Contributor

@natalia-fitzgerald @billhimmelsbach Does the beta banner need to be fixed to the top so that even when the user scrolls down -- said user still sees the banner?

@billhimmelsbach
Copy link
Contributor Author

billhimmelsbach commented May 22, 2024

@natalia-fitzgerald @billhimmelsbach Does the beta banner need to be fixed to the top so that even when the user scrolls down -- said user still sees the banner?

@shindigira @natalia-fitzgerald I don't think the designs had it fixed when we discussed it, and I'd probably argue that having it follow the user would be a lot heh. 🟨 👀

@natalia-fitzgerald
Copy link

natalia-fitzgerald commented May 22, 2024

@natalia-fitzgerald @billhimmelsbach Does the beta banner need to be fixed to the top so that even when the user scrolls down -- said user still sees the banner?

@shindigira @natalia-fitzgerald I don't think the designs had it fixed when we discussed it, and I'd probably argue that having it follow the user would be a lot heh. 🟨 👀

If we're following the CFPB default approach, and I believe that was our intent, it appears that the banner is not "fixed" to the top (does not follow the user as they scroll down the page). Here it is implemented: https://beta.consumerfinance.gov/

If there's a desire to consider a "fixed" beta banner we can discuss post MVP. But I think what you've implemented captures the design and the CFPB approach we were modeling.

@billhimmelsbach
Copy link
Contributor Author

billhimmelsbach commented May 22, 2024

If there's a desire to consider a "fixed" beta banner we can discuss post MVP. But I think what you've implemented captures the design and the CFPB approach we were modeling.

No desire from me. I think it would be a little weird for it to be fixed, so I'm happy as it is now and have it remain the same post-mvp @natalia-fitzgerald 👍

@billhimmelsbach billhimmelsbach marked this pull request as draft May 28, 2024 15:58
@billhimmelsbach billhimmelsbach marked this pull request as ready for review May 28, 2024 17:25
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@billhimmelsbach billhimmelsbach merged commit 9ace385 into main May 28, 2024
4 checks passed
@billhimmelsbach billhimmelsbach deleted the 559-beta-banner-and-alert branch May 31, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add beta and legal language to home page and top banner
4 participants