Add backwards-compatible SVG breadcrumb icons #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wagtail 2.11 adds SVG icons to admin breadcrumbs. This change adds those SVG icons to the Flags admin pages. It also adds a context variable to determine whether or not the SVG breadcrumb icons are available, and if not, falls back on the old style of breadcrumbs. I've also taken the opportunity to define this context variable and 2.10's "action" item change in a single location in `views.py`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wagtail 2.11 adds SVG icons to admin breadcrumbs. This PR adds those SVG icons to the Flags admin pages. It also adds a context variable to determine whether or not the SVG breadcrumb icons are available, and if not, falls back on the old style of breadcrumbs. I've also taken the opportunity to define this context variable and 2.10's "action" item change in a single location in
views.py.I'm not really satisfied with creating a placeholder
icontemplate tag nor with the feature-fencing context variables passing to templates, but I'm not sure of a better way. I'm very open to alternatives.