Draft: Wagtail 4.2 support

[katdom13]

• Updated tox testing and workflow actions
• Removed support for Wagtail versions < 4.1
• Suppress warnings
• Code cleanup

All tests run OK

Found 19 test(s).
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
...................
----------------------------------------------------------------------
Ran 19 tests in 0.920s

OK

[chosak]

Thank you @katdom13! We don't typically make packages releases for Wagtail release candidates but can definitely do this once 4.2 is out.

Along with this change we could probably also remove 4.0 from the tox/GitHub testing matrix - we should keep 4.1 as it's an LTS but explicitly testing 4.0 doesn't seem necessary. Any thoughts @willbarton?

[katdom13]

Hi @chosak and @willbarton ,
I have removed versions of Wagtail < 4.1 from the testing matrix.

Would you also like me to drop support for Wagtail < 4.1 altogether? This would also mean removing code inside conditionals (e.g. inside if WAGTAIL_VERSION >= (x, y)) according to [the guidelines]?(https://github.com/wagtail/wagtail/wiki/Python-Package-Maintenance-Guidelines#setuppy--setupcfg--pyprojecttoml)

Please note the EOL and support: https://endoflife.date/wagtail

Thank you!

[katdom13]

Hi @chosak , @willbarton
This MR should drop versions of Wagtail < 4.1.
Thanks!

[nickmoreton]

LGTM. Just a couple of possible changes

[nickmoreton]

Could this be removed and below you can then not need to use the CORE_BLOCKS and use the full string.

e.g. wagtail.blocks.field_block.CharBlock

[katdom13]

Hi @nickmoreton ,
Good catch! This has been updated in the latest commit b2e4161
This should also resolve the one below.

[nickmoreton]

Ditto

[nickmoreton]

LGTM 👍

[willbarton]

@katdom13 for us, it would be preferable to maintain Wagtail 2.15 support a bit longer, as that's where we currently are (but are in the process of updating).

Our preference is to test against LTS releases, so that would be 2.15 and 4.1. Unfortunately that means also maintaining the if WAGTAIL_VERSION >= (x, y) tests for now.

[nickmoreton]

@katdom13 for us, it would be preferable to maintain Wagtail 2.15 support a bit longer, as that's where we currently are (but are in the process of updating).

Our preference is to test against LTS releases, so that would be 2.15 and 4.1. Unfortunately that means also maintaining the if WAGTAIL_VERSION >= (x, y) tests for now.

Thanks @willbarton

@katdom13 If you will have time to look at this that would be great but let me know if you would like me to pick it up? Thanks

[willbarton]

@katdom13 @nickmoreton I can pick this up. We're in the midst of converting our projects to pyproject.toml too, so I'm going to pick up the commits here, do that conversion and we'll do a release based on that.

Thanks for your patience!

[willbarton]

Thank you so much @katdom13 and @nickmoreton! These changes have been merged in #67 (fascinating that GitHub sees that and indicates this PR is merged now too!)

We'll get a release out with them shortly!