Use PyCryptodomex's implementation of TurboSHAKE128 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/323
branch
from
bdf3a72
to
4b791c4
Compare
cjpatton
force-pushed
the
cjpatton/323
branch
2 times, most recently
from
0877faf
to
362d1f4
Compare
divergentdave
approved these changes
Jan 11, 2024
Support for TurboSHAKE was recently (as of version 3.20.0) added to PyCryptodomex. Use it instead of our own implementation and remove our implementation. Accordingly, remove the draft-irtf-cfrg-kangarootwelve submodule, as we no longer need it for interop testing with our code. Note that PyCryptodomex can be upgraded with: $ sage -pip install --upgrade pycryptodomex
cjpatton
force-pushed
the
cjpatton/323
branch
from
362d1f4
to
1cd5941
Compare
divergentdave
approved these changes
Jan 11, 2024
cjpatton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323.
Support for TurboSHAKE was recently (as of version 3.20.0) added to PyCryptodomex. Use it instead of our own implementation and remove our implementation.
Accordingly, remove the draft-irtf-cfrg-kangarootwelve submodule, as we no longer need it for interop testing with our code.
Note that PyCryptodomex can be upgraded with:
$ sage -pip install --upgrade pycryptodomex