-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks that prefix counts are consistent across multiple VDAF executions #332
Conversation
9560fe9
to
bb7ef65
Compare
Co-authored-by: Christopher Patton <cpatton@cloudflare.com>
Co-authored-by: Christopher Patton <cpatton@cloudflare.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be on the right track, modulo our conversation today about compatibility with DP. I think the only thing that would change is enforcing count consistency, in which case we would take some version of this PR no matter what the outcome is.
I'd suggest implementing in the reference code so that we can unit test is_valid() and make sure the changes to the rest of the construction still pass our current tests. If you like you can leave out the count checks.
Co-authored-by: Christopher Patton <cpatton@cloudflare.com>
Co-authored-by: Christopher Patton <cpatton@cloudflare.com>
Co-authored-by: Christopher Patton <cpatton@cloudflare.com>
Following the discussion in this doc, it seems clear that differential privacy is required to implement heavy hitters privately. For now, this PR only ensures that the tree is traversed correctly (i.e., not on arbitrary leaves; see mitigation 1 here). The details of how to add differential privacy to a heavy hitters protocol based on Poplar should be specified in the higher-level protocol, as VDAF doesn't have any syntax for DP (like privacy parameters). There are also different ways to implement DP here, so this is not something we want to restrict in VDAF. |
7789357
to
15299a7
Compare
Co-authored-by: David Cook <dcook@divviup.org>
Co-authored-by: David Cook <dcook@divviup.org>
Co-authored-by: David Cook <dcook@divviup.org>
Co-authored-by: David Cook <dcook@divviup.org>
Co-authored-by: David Cook <dcook@divviup.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I think we could increase test coverage a bit.
Co-authored-by: Christopher Patton <cpatton@cloudflare.com>
Co-authored-by: David Cook <dcook@divviup.org>
Co-authored-by: David Cook <dcook@divviup.org>
Fixes #316