flp: Make the output of Valid a vector
#355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to update this to speak in terms of "max_measurement" rather than "measurement_bound" per @divergentdave's comment here: #349 (comment) |
cjpatton
force-pushed
the
cjpatton/262/1
branch
2 times, most recently
from
a628443
to
6ada854
Compare
cjpatton
force-pushed
the
cjpatton/262/1
branch
2 times, most recently
from
046c320
to
dea8cb6
Compare
junyechen1996
approved these changes
Jun 13, 2024
divergentdave
approved these changes
Jun 13, 2024
If the input is valid, then each output should be zero. To save bandwidth, we generate an extra element of query randomness and use it to reduce the result. To exercise this feature, implement a new circuit, `Sum2`, that generalizes `Sum` to support any bound, including non-powers-of-two. Co-authored-by: David Cook <dcook@divviup.org>
|
Rebased and squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262.
Partially addresses #306.
If the input is valid, then each output should be zero. To save bandwidth, we generate an extra element of query randomness and use it to reduce the result.
To exercise this feature, implement a new circuit,
Sum2, that generalizesSumto support any bound, including non-powers-of-two.