Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra cleanup part1 #40

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Infra cleanup part1 #40

merged 7 commits into from
Apr 5, 2024

Conversation

tbody-cfs
Copy link
Collaborator

  • Moves default units to a separate YAML file
  • Removes named_options.Algorithms
  • Makes an autogenerated algorithms.yaml file describing the inputs and outputs of each algorithm
  • Make a wrapper to make an Algorithm for a function

@tbody-cfs tbody-cfs requested a review from hassec April 4, 2024 15:11
@tbody-cfs
Copy link
Collaborator Author

Replaces #39

@tbody-cfs tbody-cfs mentioned this pull request Apr 4, 2024
Closed
@nelsonand
Copy link
Contributor

We will check this!

@nelsonand
Copy link
Contributor

@aarooshgr This is the new algorithm format we talked about

hassec
hassec reviewed Apr 5, 2024
View reviewed changes
cfspopcon/__init__.py Show resolved Hide resolved
cfspopcon/algorithm_class.py Show resolved Hide resolved
cfspopcon/unit_handling/default_units.py Show resolved Hide resolved
tests/test_docs.py Show resolved Hide resolved
@tbody-cfs tbody-cfs mentioned this pull request Apr 5, 2024
Merged
@hassec hassec merged commit 656c65e into main Apr 5, 2024
7 checks passed
@hassec hassec deleted the infra_cleanup_part1 branch April 5, 2024 20:51
@hassec hassec mentioned this pull request Apr 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassec hassec hassec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbody-cfs @nelsonand @hassec