-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(heading): add heading component #328
Open
Amil-Gaoul
wants to merge
1
commit into
master
Choose a base branch
from
feature/heading
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apust
requested changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Сломался тест сборки:
ERROR: src/heading/heading.module.ts:4:34 - error TS2307: Cannot find module '@elephas/angular-core' or its corresponding type declarations.
52
53
4 import {EBreadcrumbsModule} from '@elephas/angular-core';
54
~~~~~~~~~~~~~~~~~~~~~~~
55
src/heading/heading.module.ts(13,9): Error during template compile of 'EHeadingModule'
56
Could not resolve @elephas/angular-core relative to [object Object]..
57
src/heading/heading.module.ts(13,9): Error during template compile of 'EHeadingModule'
58
Could not resolve @elephas/angular-core relative to [object Object]..
59
Can't bind to 'isPassive' since it isn't a known property of 'a'. ("et breadcrumb of breadcrumbs"
60
[routerLink]="breadcrumb.url"
61
[ERROR ->][isPassive]="breadcrumb.url === null">
62
{{ breadcrumb.label }}
63
</a")
64
'e-breadcrumbs' is not a known element:
65
1. If 'e-breadcrumbs' is an Angular component, then verify that it is part of this module.
66
2. If 'e-breadcrumbs' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress this message. ("ine-actions]="!breadcrumbs?.length">
67
<ng-container *ngIf="breadcrumbs?.length">
68
[ERROR ->]<e-breadcrumbs class="_e_breadcrumbs">
69
<a
70
eBreadcrumbItem
71
")
72
73
An unhandled exception occurred: src/heading/heading.module.ts:4:34 - error TS2307: Cannot find module '@elephas/angular-core' or its corresponding type declarations.
74
75
4 import {EBreadcrumbsModule} from '@elephas/angular-core';
76
~~~~~~~~~~~~~~~~~~~~~~~
77
src/heading/heading.module.ts(13,9): Error during template compile of 'EHeadingModule'
78
Could not resolve @elephas/angular-core relative to [object Object]..
79
src/heading/heading.module.ts(13,9): Error during template compile of 'EHeadingModule'
80
Could not resolve @elephas/angular-core relative to [object Object]..
81
Can't bind to 'isPassive' since it isn't a known property of 'a'. ("et breadcrumb of breadcrumbs"
82
[routerLink]="breadcrumb.url"
83
[ERROR ->][isPassive]="breadcrumb.url === null">
84
{{ breadcrumb.label }}
85
</a")
86
'e-breadcrumbs' is not a known element:
87
1. If 'e-breadcrumbs' is an Angular component, then verify that it is part of this module.
88
2. If 'e-breadcrumbs' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress this message. ("ine-actions]="!breadcrumbs?.length">
89
<ng-container *ngIf="breadcrumbs?.length">
90
[ERROR ->]<e-breadcrumbs class="_e_breadcrumbs">
91
<a
92
eBreadcrumbItem
93
")
По самому компоненту все ОК 👍 |
Amil-Gaoul
force-pushed
the
feature/heading
branch
from
February 17, 2021 05:08
c761c7e
to
25f3347
Compare
Amil-Gaoul
force-pushed
the
feature/heading
branch
from
February 17, 2021 05:22
25f3347
to
78a4a40
Compare
apust
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.