Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easing properties are not correctly transpiled #2

Closed
cfuendev opened this issue Feb 4, 2023 · 2 comments
Closed

Easing properties are not correctly transpiled #2

cfuendev opened this issue Feb 4, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cfuendev
Copy link
Owner

cfuendev commented Feb 4, 2023

Wooo these bugs just keep coming in, don't they?

When trying out Goober's css tag/macro paired with Twimba to auto-generate classes (Which could help achieving support for modifiers, breakpoints and such), I stumbled upon this:

image

Now I realize that I've missed some custom properties like ead and eaf, which shouldn't be transformed to their longer name (i.e ease-all-duration and ease-all-function, respectively), but rather, to the css properties they represent (in this case, transition-all, transition-duration and transition-timing-function).

@cfuendev
Copy link
Owner Author

cfuendev commented Feb 9, 2023

Done! Given the string:
image
The CSS output is:
image

This will be patched in Imba v0.3.2

However, I still have to test that two-letter shorthands (Whose values follow the duration | function? | delay? syntax) are not messed up in the output.

@cfuendev cfuendev changed the title Custom transition properties are not correctly transpiled Easing properties are not correctly transpiled Feb 9, 2023
@cfuendev
Copy link
Owner Author

GUESS WHAT? I FINALLY FIXED IT. Some flag trickery, a bit of coffee, re-learning the inner workings of the compiler, some heavy debugging, and voilâ, two-letter shorthands are transpiled correctly!

Given the string:
image
The CSS output is:
image

I can finally release Imba v0.3.2. Thanks for your patience!

cfuendev added a commit that referenced this issue Apr 20, 2023
cfuendev added a commit that referenced this issue Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant