An alternative way to provide correct stacktraces #1723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhnroyal
added
s: feature
7 tasks
kuhnroyal
commented
Mar 8, 2023
| await dio.get('/foo'); | ||
| } catch (e, stackTrace) { | ||
| expect(stackTrace, isA<Chain>()); | ||
| expect(stackTrace.toString(), contains('test/stacktrace_test.dart')); |
There was a problem hiding this comment.
We have there correct stacktrace here, something like this:
package:dio/src/dio_mixin.dart 556:7 DioMixin.fetch.<fn>
===== asynchronous gap ===========================
dart:async Future.catchError
package:dio/src/dio_mixin.dart 549:8 DioMixin.fetch
package:dio/src/dio_mixin.dart 392:36 DioMixin.request.<fn>.<fn>
===== asynchronous gap ===========================
dart:async new Future
package:dio/src/dio_mixin.dart 365:15 DioMixin.request.<fn>
package:stack_trace Chain.capture
package:dio/src/dio_mixin.dart 364:13 DioMixin.request
package:dio/src/dio_mixin.dart 63:12 DioMixin.get
test/stacktrace_test.dart 15:19 main.<fn>.<fn>
package:test_api/src/backend/declarer.dart 215:19 Declarer.test.<fn>.<fn>
There was a problem hiding this comment.
This looks pretty good, but I am not sure if tooling like Sentry/Crashlytics can work with this.
kuhnroyal
commented
Mar 8, 2023
| } catch (e, stackTrace) { | ||
| expect(stackTrace, isNot(isA<Chain>())); | ||
| expect(stackTrace.toString(), | ||
| isNot(contains('test/stacktrace_test.dart'))); |
There was a problem hiding this comment.
Here we have no usable stacktrace.
|
|
If I had to guess, I would think most people are already using a higher Dart version |
|
I am closing this, this is very interesting with nice stacktraces and all but it is not the way to go inside a library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)