Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http2_adapter] 🐛 Support HTTP/1.x for proxy responses #2054

Merged
merged 7 commits into from
Jan 16, 2024

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Dec 4, 2023

Fixes #2053.

According to RFC 2616/9110, protocols with the same major version will be allowed in responses.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Signed-off-by: Alex Li <github@alexv525.com>
@AlexV525

This comment was marked as resolved.

@AlexV525 AlexV525 marked this pull request as ready for review December 9, 2023 02:47
@AlexV525 AlexV525 requested a review from a team as a code owner December 9, 2023 02:47
@AlexV525 AlexV525 added the p: http2_adapter Targeting `http2_adapter` package label Dec 14, 2023
@AlexV525
Copy link
Member Author

@cfug/devs This one should be good to go.

Copy link
Member

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have no way/time to test this.

@AlexV525 AlexV525 merged commit adc6842 into main Jan 16, 2024
3 checks passed
@AlexV525 AlexV525 deleted the fix/major-version-protocols branch January 16, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: http2_adapter Targeting `http2_adapter` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issues HTTP_PROXY returns HTTP/1.0 200 Connection established
2 participants