Split the web support to package dio_browser_adapter #2218
Conversation
|
Oops, |
|
A tough problem : ( |
| @@ -4,6 +4,7 @@ import 'dart:typed_data'; | |||
| import 'package:meta/meta.dart'; | |||
|
|
|||
| import 'adapters/io_adapter.dart' | |||
| if (dart.library.js_util) 'adapters/browser_adapter.dart' | |||
| if (dart.library.html) 'adapters/browser_adapter.dart' as adapter; | |||
There was a problem hiding this comment.
This line should be removed. ALL references to dart:html and dart.library.html should be removed.
There was a problem hiding this comment.
Actually removing these might require upping the min Dart version to 3.3 which isn't ideal
There was a problem hiding this comment.
This line should be removed. ALL references to
dart:htmlanddart.library.htmlshould be removed.
Will this cause WASM to degrade or something related?
There was a problem hiding this comment.
I'm not sure. All I know is the migration docs say to remove them.
There was a problem hiding this comment.
Since this is an import condition it shouldn't cause any issues, but the js_util ones definitely need changed to js_interop as js_util is one of the deprecated web packages
There was a problem hiding this comment.
I think the imports are resolved at compile time, so it should be fine. But definitely should switch to the new js_interop package. We need to figure out if it is possible to run our adapter test in WASM, that will tell us that it is working
| @@ -4,6 +4,7 @@ import 'dart:typed_data'; | |||
| import 'package:meta/meta.dart'; | |||
|
|
|||
| import 'adapters/io_adapter.dart' | |||
| if (dart.library.js_util) 'adapters/browser_adapter.dart' | |||
There was a problem hiding this comment.
This should be dart.library.js_interop as mentioned here: https://dart.dev/interop/js-interop/package-web#conditional-imports
| @@ -25,7 +25,9 @@ | |||
|
|
|||
| import 'dart:async'; | |||
|
|
|||
| import 'compute_io.dart' if (dart.library.html) 'compute_web.dart' as _c; | |||
| import 'compute_io.dart' | |||
| if (dart.library.js_util) 'compute_web.dart' | |||
| @@ -3,6 +3,7 @@ import 'dart:async'; | |||
| import 'adapter.dart'; | |||
| import 'cancel_token.dart'; | |||
| import 'dio/dio_for_native.dart' | |||
| if (dart.library.js_util) 'dio/dio_for_browser.dart' | |||
| @@ -15,6 +15,7 @@ import 'headers.dart'; | |||
| import 'interceptors/imply_content_type.dart'; | |||
| import 'options.dart'; | |||
| import 'progress_stream/io_progress_stream.dart' | |||
| if (dart.library.js_util) 'progress_stream/browser_progress_stream.dart' | |||
| @@ -4,6 +4,7 @@ import 'dart:convert'; | |||
| import 'package:http_parser/http_parser.dart'; | |||
|
|
|||
| import 'multipart_file/io_multipart_file.dart' | |||
| if (dart.library.js_util) 'multipart_file/browser_multipart_file.dart' | |||
|
Closing in favor of #2223 |
#2215 (comment)
Prepare to adapt WASM.