Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie problem #112

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Cookie problem #112

merged 3 commits into from
Aug 19, 2020

Conversation

capoaira
Copy link
Contributor

New PR which includes also the old dashboard and a bit cleaner code
The following will change by this PR:
Add a Settingsbutton to the

The Settings:
grafik
The infotext will not be show by default. Only if you click on the ?-Button

@Lineflyer, please test it

Copy link
Collaborator

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

See the complete overview on Codacy

@Lineflyer
Copy link
Member

Will test it on master and merge to release once tested.

For my understanding:

  • The script should work as before on Firefox and on "unaffected" Chrome
  • With the problematic Chrome the user needs to change the new setting, afterwards it works as before

Correct?

@Lineflyer Lineflyer merged commit c88acb3 into cgeo:master Aug 19, 2020
@Lineflyer
Copy link
Member

My assumptions seem to be correct. Just tested 0.51 from master and it works with both Firefox and Chrome (with activated setting).

@capoaira
Stupid question:
Couldn't we get rid of the whole "third party cookie" problem if we use this option permanently and as a default without setting?

For two reasons:

  • It difficult to explain Chrome users to apply this setting as we do not have a good communication channel
  • Firefox might some day apply the same third party cookie blocking

@capoaira
Copy link
Contributor Author

Yes, but for me the Window closed directly after loading and so I don't see if sending was successful or if I have to register first.
Because of that I have made the settings, so that all can use the old one.

I think in the long term, we should switch to a solution without third-party cookies. That needs changes in the server code. Than we can save the register data in Tampermonkay. So it isn't use cookies and the registration will not go list after some time.

@capoaira
Copy link
Contributor Author

For my understanding:

  • The script should work as before on Firefox and on "unaffected" Chrome
  • With the problematic Chrome the user needs to change the new setting, afterwards it works as before

Correct?

Yes

@Lineflyer
Copy link
Member

Will merge to release branch now, so that version 0.51 is live.

I will add a FAQ entry regarding the setting in Chrome in case of problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants