Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment class implementing volume checks and tracking. #16

Merged
merged 11 commits into from
Aug 21, 2022
Merged

Conversation

cgevans
Copy link
Owner

@cgevans cgevans commented Aug 20, 2022

This pull request has an Experiment class, which takes a series of mixes, and tracks volumes produced and consumed.

There are some questions that need to be resolved:

  • This currently has tracks mixes and components by name. This may be reasonably safe for mixes, but is not safe for components (may be reordered, etc). It would be better have some better reference method, though this may not be immediately necessary.
  • The Experiment class uses a list of mixes / components. It may be better to have it use, eg, an ordereddict, keeping track of names. This would also make the Experiment a convenient way to store/refer to mixes.

Partially closes #4, closes #14, partially closes #13.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #16 (dfe2273) into main (b9fc5fe) will increase coverage by 4.34%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   68.35%   72.69%   +4.34%     
==========================================
  Files          12       14       +2     
  Lines        1694     1934     +240     
==========================================
+ Hits         1158     1406     +248     
+ Misses        536      528       -8     
Impacted Files Coverage Δ
src/alhambra_mixes/locations.py 71.91% <ø> (-0.20%) ⬇️
src/alhambra_mixes/quantitate.py 53.97% <0.00%> (ø)
src/alhambra_mixes/util.py 100.00% <ø> (+11.11%) ⬆️
src/alhambra_mixes/dictstructure.py 61.53% <61.53%> (ø)
src/alhambra_mixes/units.py 78.50% <64.28%> (-2.15%) ⬇️
src/alhambra_mixes/actions.py 85.71% <71.18%> (-3.36%) ⬇️
src/alhambra_mixes/components.py 88.77% <89.74%> (+0.57%) ⬆️
src/alhambra_mixes/mixes.py 67.19% <95.00%> (+12.40%) ⬆️
src/alhambra_mixes/__init__.py 100.00% <100.00%> (ø)
src/alhambra_mixes/abbreviated.py 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cgevans cgevans marked this pull request as ready for review August 21, 2022 01:17
@cgevans cgevans merged commit e63a22f into main Aug 21, 2022
@cgevans cgevans deleted the experiment branch November 1, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants