support ethPrice config
#116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reasons `eth-gas-reporter` config option `ethPrice` (see: https://github.com/cgewecke/eth-gas-reporter/blob/deadc079f1920590ea362fdd6e0e008e70e4f95f/lib/config.js#L17) isn't currently supported. This should also solve: cgewecke#82 - see: https://github.com/cgewecke/eth-gas-reporter/blob/deadc079f1920590ea362fdd6e0e008e70e4f95f/lib/utils.js#L170-L178
|
I think its useful for me cuz i don't want to get eth price from network cuz i have a bad network. anyone can review this pr and merge it? |
rudolfolah
approved these changes
Dec 4, 2022
|
Please merge this @navigatrum @magiconch @rudolfolah |
|
Apologies for the (very long) delay reviewing here. This is supported in the latest major release as the https://github.com/cgewecke/hardhat-gas-reporter/releases/tag/v2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reasons
eth-gas-reporterconfig optionethPrice(see: https://github.com/cgewecke/eth-gas-reporter/blob/deadc079f1920590ea362fdd6e0e008e70e4f95f/lib/config.js#L17 ) isn't currently supported.This should also solve: #82 - see: https://github.com/cgewecke/eth-gas-reporter/blob/deadc079f1920590ea362fdd6e0e008e70e4f95f/lib/utils.js#L170-L178