Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add viem support & tests #177

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Add viem support & tests #177

merged 2 commits into from
Feb 20, 2024

Conversation

cgewecke
Copy link
Owner

@cgewecke cgewecke commented Feb 20, 2024 •
edited
Loading

#170

Ports #167, #157 to beta.

  • Adds recording for eth_sendTransaction if viem is exposed on the environment.
    • if users mix viem with hardhat-ethers, the ethers call counts will be doubled
  • Adds tests for transactions executed with public and wallet clients.
  • Issues highlighted in Missing viem support #157 about import order and wallet client txs missing are resolved by using extendProvider in the beta branch

Closes #167

@cgewecke cgewecke merged commit 354a3f4 into beta Feb 20, 2024
1 check passed
@cgewecke cgewecke deleted the add-viem-test branch February 20, 2024 06:08
This was referenced Feb 20, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgewecke @muhammetaliakbay