partial fix for #88 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added cover for garage
fixed position of cover
change device_class to garage
|
Hi! Thank you for your support. At first glance, this may work, but only if you are using a "normal" entity (not the one with custom icons). I will have a closer look at your PR later today. |
|
Yes, it is currently set as a generic entity, not a custom icon. |
cgiesche
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I came up with. It still doesn't work, though, and I'm not sure why, so I must be missing something. At any rate, I'm hoping this code at least gives you a starting point. I see it initially load up with the correct "closed" icon, but once it establishes communication with home assistant, the icon disappears.
#88
Feel free to hit me up directly with any ideas you might have. Happy to test locally.