align date formats #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgoldberg Forgot to mention. Tests pass, except that I was unable to get python3.2 to install with Homebrew. If you have any suggestions there let me know, but you should pull it and run tox before you merge it to double check for any python3.2 issues. I don't think there would be any, however. |
|
@eriktaubeneck, I'll merge your pull request now. |
cgoldberg
added a commit
that referenced
this pull request
Apr 27, 2013
changed date formats in get_historical_prices from YYYYMMDD to YYY-MM-DD
skillachie
pushed a commit
to skillachie/ystockquote
that referenced
this pull request
Jul 22, 2014
changed date formats in get_historical_prices from YYYYMMDD to YYY-MM-DD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the date format to be consistently '[YYYY]-[MM]-[DD]'. It does, however, break the API, but I think supporting both formats would be overly complex - "There should be one-- and preferably only one --obvious way to do it."