Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return value on application success. #1

Merged
merged 1 commit into from
Dec 5, 2016

Conversation

jlgreathouse
Copy link
Contributor

This PR changes the return values of all of the benchmarks. Right now, if one of the chai programs succeeds, it turns 1. Per generally accepted Unix standards, however, a value of '0' is indicative of success.

See, for instance:
POSIX Standard for exit -- "A value of zero (or EXIT_SUCCESS, which is required to be zero) for the argument status conventionally indicates successful termination."
Linux Documentation - "A successful command returns a 0, while an unsuccessful one returns a non-zero value that usually can be interpreted as an error code"

Returning a non-zero value from these benchmarks makes them difficult to run in scripted systems.

@el1goluj el1goluj merged commit fadcfe7 into chai-benchmarks:master Dec 5, 2016
@jlgreathouse jlgreathouse deleted the fix_returns branch December 5, 2016 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants