Update return value on application success. #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the return values of all of the benchmarks. Right now, if one of the chai programs succeeds, it turns 1. Per generally accepted Unix standards, however, a value of '0' is indicative of success.
See, for instance:
POSIX Standard for exit -- "A value of zero (or EXIT_SUCCESS, which is required to be zero) for the argument status conventionally indicates successful termination."
Linux Documentation - "A successful command returns a 0, while an unsuccessful one returns a non-zero value that usually can be interpreted as an error code"
Returning a non-zero value from these benchmarks makes them difficult to run in scripted systems.