Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor worker class #2651

Merged
merged 2 commits into from Mar 5, 2024
Merged

Refactor worker class #2651

merged 2 commits into from Mar 5, 2024

Conversation

RunDevelopment
Copy link
Member

Changes:

  • Rename classes and variables to "worker".
  • No more two-step construction for the worker process class.
  • Don't look for a specific message in stdout to determine whether the worker process is ready. Instead, look for whether its port is used + try to connect to it.
  • Make pretty much all class fields private.
  • Combine wait_for_server_start and wait_for_backend_ready into wait_for_ready.

@joeyballentine joeyballentine merged commit 6a312a8 into chaiNNer-org:main Mar 5, 2024
14 checks passed
@RunDevelopment RunDevelopment deleted the refactor-worker-server branch March 5, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RunDevelopment @joeyballentine