Fix tests and issues around be function #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 2, 2014 16:38
No longer an issue (there is a test verifying this) and the workaround does not work.
|
Sorry. I misread that. Then this does not address #30. |
This reverts commit 6fb83b1.
|
Thanks, I've cherry picked some individual commits from this. The "contains handles quotes" problem is more general, in that the contains assertion should be escaping quotes but isn't, and from what I've been able to find, doing so isn't even supported by jQuery. So we may need to just drop that from the test suite. For now I've pinned a jQuery version for which the test passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lengthworkaround doesn't work #30 Officiallengthworkaround doesn't work