Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bower.json to chai-spies package #36

Merged
merged 1 commit into from
Sep 21, 2015
Merged

Add bower.json to chai-spies package #36

merged 1 commit into from
Sep 21, 2015

Conversation

rcchen
Copy link

@rcchen rcchen commented Sep 18, 2015

Fixes #13

@keithamus
Copy link
Member

@rcchen thanks. Could you please remove the version field from the json, as bower does not use it and its a pain to maintain anyway.

@rcchen
Copy link
Author

rcchen commented Sep 21, 2015

@keithamus removed the version line, should be good to go now.

Just for personal understanding, bower relies on Git release tags for versioning, correct?

@keithamus
Copy link
Member

@rcchen yup! @kkirsche has the deets over in chaijs/chai#468 - linking to an SO post: https://stackoverflow.com/questions/24844901/bowers-bower-json-file-version-property:

Bower currently ignores version from bower.json.

If the version in bower.json doesn't match git tag, you get a warning, and the version entry in generated .bower.json is fixed (version in bower.json stays the same).

Among others that's why bower plugins should consume.bower.json instead bower.json.

You can safely remove version from your bower.json. Bower only respects git tags.

Most probably it won't be used even in the future.

keithamus added a commit that referenced this pull request Sep 21, 2015
Add bower.json to chai-spies package
@keithamus keithamus merged commit c8b1244 into chaijs:master Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants