Update getName to fix inspect in Firefox #806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing in Firefox after #789 was merged because
Function.prototype.toString
doesn't work on proxified functions per this article. I traced the specific error to this line, which was being called by Chai'sinspect
.Replacing the logic in Chai's
getName
with @lucasfcosta's logic fromgetConstructorName
in the check-error repository fixed the problem without breaking any tests.Not sure it's worth it to pull that function into a separate module that's required by both Chai and check-error; seems like it might be overkill. An alternative would be for check-error to expose the function for Chai to require, but that doesn't quite feel right either. I'm okay with the duplicate logic across repos here, but if someone feels strongly otherwise I'm easily swayed.