fix: self-building payloads in kurtosis devnet #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: thedevbirb <lorenzo@chainbound.io>
Co-authored-by: thedevbirb <lorenzo@chainbound.io>
merklefruit
force-pushed
the
feat/sign-header
branch
from
f4ff126
to
a20a4eb
Compare
merklefruit
changed the title
get_header response with fallback payloads
merklefruit
commented
Jul 3, 2024
Comment on lines
117
to
+118
| // TODO: add included blobs here | ||
| blobs_bundle: None, | ||
| blobs_bundle: Default::default(), |
There was a problem hiding this comment.
we should add an issue for this: support blobs across the self building pipeline
thedevbirb
approved these changes
Jul 3, 2024
Comment on lines
+103
to
+111
| /// Get the slot time for the given chain in seconds. | ||
| pub fn slot_time(&self) -> u64 { | ||
| match self { | ||
| Chain::Mainnet => 12, | ||
| Chain::Holesky => 12, | ||
| Chain::Kurtosis => 2, | ||
| Chain::Helder => 12, | ||
| } | ||
| } |
There was a problem hiding this comment.
I'd still keep the slot time as a separate CLI arg, with default 12, in case we want to run the devnet with a more realistic slot time. We can do it in a separate PR
There was a problem hiding this comment.
Yeah we should refactor the Chain configs to another file perhaps
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_headerresponse with fallback payloads