Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubsub v1 #9

Merged
merged 36 commits into from
Oct 19, 2023
Merged

Pubsub v1 #9

merged 36 commits into from
Oct 19, 2023

Conversation

mempirate
Copy link
Contributor

No description provided.

@mempirate
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mempirate
feat(wire): add pubsub codec
322fa6d
@mempirate
refactor(wire): rm unused
2f8f99e
@mempirate
feat(socket): initial sub socket implementation
dfad88c
@mempirate
feat(socket): SubMessage getters
1b1e6b3
@mempirate
fix(transport): async connect
a388bcd
@mempirate
test(bench): use blocking connect with benchmark
2d0cc9d
@mempirate
test(bench): switch to current thread Tokio runtime
13ed443
@mempirate
fix(transport): blocking connect with auth
f410040
@mempirate
feat(socket): initial pub socket implementation
60bd041
@mempirate
misc(socket): typos
6cdc952
@mempirate
fix(wire): codec logic bug
abf88e1
@mempirate
feat(socket): pub sub implementation fixes, options & perf
2c6df70
@mempirate
test(bench): add more pubsub benchmarks
63025d9
@mempirate
test(bench): fix Divan benchmarks
fc4858a
@mempirate
test(bench): disable single thread bench
1ede51d
@mempirate
test(bench): clean up pubsub bench
fc67cd3
@mempirate
test(bench): enable and fix single threaded pusbub test
a36fc04
@mempirate
feat(socket): change new with options interface
d9c65fb
@mempirate
feat(socket): clean up pub socket, add stats
7c50a41
@mempirate
refactor(socket): pub socket clean up
7b3ab0b
@mempirate
test(bench): multiple subscribers pubsub bench
fef806f
@mempirate
test(pubsub): durable tests
1f6012d
@mempirate
doc(msg): add examples
f13564f
@mempirate
fix(transport): add Sync to a Future, unaware of the consequences
8f99004
@mempirate
doc(msg): fix pubsub example
14792d2
@mempirate
doc: update README
2a4327d
@mempirate mempirate marked this pull request as ready for review October 18, 2023 18:48
@mempirate mempirate mentioned this pull request Oct 18, 2023
Closed
merklefruit
merklefruit requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very impressive, just left some comments to understand some parts

msg/benches/pubsub.rs Outdated Show resolved Hide resolved
msg/benches/pubsub.rs Show resolved Hide resolved
msg-socket/src/pub/driver.rs Show resolved Hide resolved
msg-socket/src/pub/mod.rs Show resolved Hide resolved
msg-socket/src/pub/trie.rs Show resolved Hide resolved
msg-socket/src/pub/session.rs Show resolved Hide resolved
msg-socket/src/pub/session.rs Outdated Show resolved Hide resolved
@merklefruit merklefruit mentioned this pull request Oct 19, 2023
Open
merklefruit
merklefruit approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@mempirate mempirate merged commit cd35949 into main Oct 19, 2023
4 checks passed
@mempirate mempirate mentioned this pull request Oct 19, 2023
Closed
@merklefruit merklefruit deleted the feature/pubsub-v1 branch December 20, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mempirate @merklefruit