Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional import of Classifier #185

Merged

Conversation

delta2323
Copy link
Member

This PR changes the Tox21 and QM9 examples to skip availability of Classifier.

Currently, code in the Tox21 and QM9 examples check if Classifier is available because previously the version we can install via pip was v0.2.0, where Classifier is not available. Now we can get v0.3.0 with pip, we do not need this conditioning.

@codecov-io
Copy link

codecov-io commented Jun 9, 2018

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   76.64%   76.64%           
=======================================
  Files          87       87           
  Lines        3712     3712           
=======================================
  Hits         2845     2845           
  Misses        867      867

Copy link
Member

@corochann corochann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corochann corochann merged commit 5b0019d into chainer:master Jun 10, 2018
@mottodora mottodora added this to the 0.4.0 milestone Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants